-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Product import: Remove line breaks in keys #35880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
barryhughes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thank you.
barryhughes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once checks pass, we can go ahead and merge 👍
Thanks @barryhughes for generating the changelog, I had trouble with pnpm on my Lando environment (nvm, and node version). It looks like the checks ran into a connectivity error? If I am not mistaken.
Any way to rerun the actions? |
Yep, that happens periodically: I triggered a re-run and we don't need to worry about the 'Build Live Branch' check failing (that's a known problem). I have it on my list to check back in on this PR a little later: we'll get it merged one way or another :-) |
Remove line breaks in keys, to avoid mismatch mapping of keys.
barryhughes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, checks are now passing (except for one which we know to be problematic). Merging: thanks again!
Thanks a lot @barryhughes ;) |
* Product import: Remove line breaks in keys Remove line breaks in keys, to avoid mismatch mapping of keys. * Fix syntax * PHPCS * Changelog. Co-authored-by: barryhughes <[email protected]>
Hello
I had problems with product import.
After some time, I managed to identify that CSV keys with line breaks cause the import to skip the column, while the mapping looks like it should have worked.
The PR remove line breaks in the keys of the CSV imported file, to avoid mismatch mapping of keys.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes product import when the CSV imported file has a line break in a key name.
If a key has a line break, mapping fields will look OK, but the import will simply skip the values of this key.
Example of a CSV file with line break below:
With a line break, the mapping looks like it will work (image below):

The PR removes line breaks in all the CSV keys.
Regular\npricebecomesRegular price.How to test the changes in this Pull Request:
Regular priceOther information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: