Add __experimentalSelectControl suffix prop #35809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR adds support for a
suffixprop on__experimentalSelectControl.New tests and stories were also added.
According to the acceptance criteria in #35426:
Additionally (this wasn't spelled out in the acceptance criteria):
suffixis set tonull, no suffix is shownI decided that a
SelectControlSuffixWrapperwasn't necessary at this time. We have no immediate need for it, and we are providing aSuffixIconcomponent that can be used to easily set a custom icon while maintaining the correct styling.If a need for a
SelectControlSuffixWrapperarises in the future it will be addressed in a separate PR.Closes #35426.
How to test the changes in this Pull Request:
pnpm --filter=@woocommerce/components run test -- src/experimental-select-controlProducts>Add new (MVP)Categoriesselect control renders properlyOther information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: