Skip to content

Conversation

@louwie17
Copy link
Contributor

@louwie17 louwie17 commented Nov 29, 2022

All Submissions:

Changes proposed in this Pull Request:

Adds the __experimentalOpenMenuOnFocus prop to the attribute and attribute term input select control fields.

Related to #35576 .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Load this branch, build it, and make sure you have the new-product-management-experience feature flag enabled (you can do so using the latest version of the Beta tester within the mono repo).
  2. Go to Products > Attributes and add some attributes
  3. Go to Product > Add New and scroll down to the attributes field
  4. Select Add first attribute and select the attribute input field
  5. The menu should open with the initial list of attributes
  6. Select an attribute that contains a couple terms
  7. Once selected the attribute term field should auto focus and open, it might initially show a loading icon, but then a list of terms.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 5337a40

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 57s
E2E Tests186006019213m 21s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@louwie17 louwie17 self-assigned this Nov 29, 2022
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louwie17 louwie17 merged commit f16cfbc into trunk Nov 30, 2022
@louwie17 louwie17 deleted the add/35576_open_on_focus_to_attribute_fields branch November 30, 2022 08:05
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants