-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Move file picker by clicking card into the MediaUploader component #35738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results SummaryCommit SHA: 7dbf34f
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
louwie17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tested well, nice work @octaedro ! 💯
| <> | ||
| <img | ||
| src={ DragAndDrop } | ||
| alt="Completed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this was from the original changes, but should this be wrapped in __(?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @louwie17!
I just pushed this fix. Could you take another quick look at this PR?
louwie17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thanks for updating the completed text 😄
All Submissions:
Changes proposed in this Pull Request:
This PR moves the code to pick a file after clicking the images card to the MediaUploader component.
Closes #35714.
How to test the changes in this Pull Request:
Choose imagesbutton).wcadmin_product_images_add_via_file_upload_areashould be recordedStorybook
Check that the storybook for the component
MediaUploaderis working as expected.Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: