Skip to content

Conversation

@octaedro
Copy link
Contributor

@octaedro octaedro commented Nov 26, 2022

All Submissions:

Changes proposed in this Pull Request:

This PR moves the code to pick a file after clicking the images card to the MediaUploader component.

Screen Capture on 2022-11-27 at 16-03-29

Closes #35714.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Check out this branch and go to Products > Add New (MVP)
  2. Click the Drag and drop area (not the Choose images button).
  3. A file picker should be visible. Pick an image.
  4. The selected image should be visible now in the gallery.
  5. The tracks event wcadmin_product_images_add_via_file_upload_area should be recorded
  6. Continue with the product creation process. Confirm that it has been created correctly.

Storybook
Check that the storybook for the component MediaUploader is working as expected.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin package: @woocommerce/components issues related to @woocommerce/components plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2022

Test Results Summary

Commit SHA: 7dbf34f

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 18s
E2E Tests186006019213m 53s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@octaedro octaedro requested a review from a team November 27, 2022 19:26
@octaedro octaedro marked this pull request as ready for review November 27, 2022 19:26
@octaedro octaedro self-assigned this Nov 27, 2022
louwie17
louwie17 previously approved these changes Nov 29, 2022
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested well, nice work @octaedro ! 💯

<>
<img
src={ DragAndDrop }
alt="Completed"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was from the original changes, but should this be wrapped in __(?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @louwie17!
I just pushed this fix. Could you take another quick look at this PR?

Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for updating the completed text 😄

@octaedro octaedro merged commit 716d5ab into trunk Nov 30, 2022
@octaedro octaedro deleted the dev/35714_move_file_picker_to_media_uploader branch November 30, 2022 12:00
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/components issues related to @woocommerce/components plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: move file picker by clicking card into the MediaUploader component

3 participants