Skip to content

Update logo icon for Google Listings and Ads in onboarding marketing task #35732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ecgan merged 2 commits into from
Nov 30, 2022
Merged

Update logo icon for Google Listings and Ads in onboarding marketing task #35732

ecgan merged 2 commits into from
Nov 30, 2022

Conversation

@ecgan
Copy link
Contributor

@ecgan ecgan commented Nov 25, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #35731.

In this PR, we change the logo icon for Google Listings and Ads in the WooCommerce onboarding marketing task (the default tasks with marketplace suggestions turned off in WooCommerce Settings), from the Google Ads icon to Google's "Big G" icon.

The change here is to be consistent with PR #34471.

I removed the old google-listings-and-ads.png and added google.svg file. google.svg is a copy of https://github.com/woocommerce/woocommerce/blob/6b3056422eee798f9a1764fc82657d92534e09d2/plugins/woocommerce/assets/images/marketing/google.svg. I checked that there are no more references to google-listings-and-ads.png.

image

How to test the changes in this Pull Request:

UI test:

  1. Make sure marketplace suggestion is turned off in WooCommerce Settings > Advanced > WooCommerce.com: /wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com.
  2. Go to WooCommerce Onboarding Marketing task: /wp-admin/admin.php?page=wc-admin&task=marketing.
  3. The Google Listings and Ads icon should be the "Big G" icon.

Code base check:

  1. Make sure there are no more references to google-listings-and-ads.png.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ecgan ecgan requested review from a team November 25, 2022 15:43
@ecgan ecgan self-assigned this Nov 25, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

Test Results Summary

Commit SHA: 3680cd8

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 8s
E2E Tests186006019214m 6s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

puntope
puntope approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Thanks Gan, I can see the new G logo instead of the old "Google drive" logo.

❓ Why when WooCommerce Marketing Suggestions is activated I see still old Google Drive Logo.

(approved in advance)

@ecgan
Copy link
Contributor Author

ecgan commented Nov 30, 2022 •
edited
Loading

❓ Why when WooCommerce Marketing Suggestions is activated I see still old Google Drive Logo.

When WooCommerce Marketing Suggestions is activated, the data would come from woocommerce.com API - see the related PR https://github.com/Automattic/woocommerce.com/pull/15184 (it has just been merged, which means it may be deployed soon and you may not see "old Google Drive Logo" anymore) (PS: It is Google Ads logo, not Google Drive logo. 😂 ).

One of the files changed in this PR is plugins/woocommerce/src/Internal/Admin/RemoteFreeExtensions/DefaultFreeExtensions.php. This is the hint that I get from the folder and file name: when the "Remote" data does not work or is turned off, use the "Default" data provided within the WooCommerce plugin. This PR deals with the "Default" one, while the PR https://github.com/Automattic/woocommerce.com/pull/15184 deals with the "Remote" one.

@ecgan ecgan merged commit ec5092b into trunk Nov 30, 2022
@ecgan ecgan deleted the fix/35731-update-google-icon branch November 30, 2022 17:35
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 30, 2022
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@puntope puntope puntope approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ecgan ecgan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

Google Listings and Ads icon in onboarding marketing task is not the right one

3 participants

@ecgan @puntope