Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Nov 25, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes https://github.com/woocommerce/team-ghidorah/issues/129

Surface Amazon Pay as "Additional Payment Options" for UK/EU/JP in additional payment task

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Use a fresh site
  2. Set woocommerce_show_marketplace_suggestions option to no.
  3. Go to OBW
  4. Select "UK" as the store country
  5. Complete OBW
  6. Set up WCPay
  7. Go to WooCommerce > Home
  8. Go to Set up additional payment options task
  9. Observe that Amazon Pay is displayed

Screen Shot 2022-11-25 at 15 00 49

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 25, 2022
@chihsuan chihsuan marked this pull request as ready for review November 25, 2022 07:36
@chihsuan chihsuan self-assigned this Nov 25, 2022
@chihsuan chihsuan requested review from a team, ilyasfoo and moon0326 November 25, 2022 07:38
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 22e10c1

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 54s
E2E Tests186006019214m 24s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM! 🚢

Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well and LGTM 🚀

@chihsuan chihsuan merged commit 1339586 into trunk Nov 28, 2022
@chihsuan chihsuan deleted the update/surface-amazon-pay branch November 28, 2022 22:30
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants