Skip to content

Add a bottom padding to the whole form #35721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdperez86 merged 1 commit into from
Nov 29, 2022
Merged

Add a bottom padding to the whole form #35721

mdperez86 merged 1 commit into from
Nov 29, 2022

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Nov 24, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #35571

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Go to Products -> Add New (MVP) page
  2. The form has a fixed padding-bottom of 128 px on desktop and tablet/mobile.

Mobile/Tablet

Desktop

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@mdperez86 mdperez86 self-assigned this Nov 24, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 18484d1

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 9s
E2E Tests186006019216m 38s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mdperez86 mdperez86 marked this pull request as ready for review November 25, 2022 17:09
louwie17
louwie17 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mdperez86 mdperez86 merged commit 79566d7 into trunk Nov 29, 2022
@mdperez86 mdperez86 deleted the enhancement/35571 branch November 29, 2022 18:11
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 29, 2022
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

@octaedro octaedro Awaiting requested review from octaedro

@mattsherman mattsherman Awaiting requested review from mattsherman

@joshuatf joshuatf Awaiting requested review from joshuatf

Assignees

@mdperez86 mdperez86

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add a bottom padding to the whole form

3 participants

@mdperez86 @louwie17