Align the field height across the whole form #35720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
package: @woocommerce/components
Contributor
Test Results SummaryCommit SHA: a77cd3c
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
mdperez86
force-pushed
the
enhancement/35567
branch
from
0a65693 to
a77cd3c
Compare
louwie17
approved these changes
Nov 25, 2022
Contributor
louwie17
left a comment
louwie17
left a comment
There was a problem hiding this comment.
LGTM 🚀 This tested well! I did leave one small comment, but the changes still looked good!
| flex-wrap: wrap; | ||
| align-items: center; | ||
| padding: $gap-smallest 36px $gap-smallest $gap-smaller; | ||
| padding: 2px 36px 2px $gap-smaller; |
Contributor
There was a problem hiding this comment.
Was using 2px still necessary versus 4px - $gap-smallest after adding the min-height: 36px?
Contributor
Author
There was a problem hiding this comment.
Yes because min-height doesn't prevent the input field growing in height if its content is greater than 36px. The [selected items height] + (2 * $gap-smallest) is greater than 36px.
Contributor
There was a problem hiding this comment.
Sounds good, thanks for the clarification :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes #35567
Closes #35566
How to test the changes in this Pull Request:
Products -> Add New (MVP)pageOther information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: