Skip to content

Update the summary placeholder text in the product management form. #35717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
octaedro merged 3 commits into from
Nov 24, 2022
Merged

Update the summary placeholder text in the product management form. #35717

octaedro merged 3 commits into from
Nov 24, 2022

Conversation

@AnnaMag
Copy link
Contributor

@AnnaMag AnnaMag commented Nov 24, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #35715

How to test the changes in this Pull Request:

  1. Enable the new product management form.
  2. Go to wp-admin/admin.php?page=wc-admin&path=%2Fadd-product.
  3. Verify that the copy in the summary section is as follows:

Screenshot 2022-11-24 at 19 29 23

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@AnnaMag AnnaMag self-assigned this Nov 24, 2022
@AnnaMag AnnaMag requested a review from octaedro November 24, 2022 18:30
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 24, 2022
@AnnaMag AnnaMag added Product/Inventory Management Issues related to product or product page. focus: product management and removed plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: react admin labels Nov 24, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 00d91b0

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 3s
E2E Tests186006019214m 25s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

octaedro
octaedro approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @AnnaMag! LGTM 🚀

@octaedro octaedro merged commit 49aa5e0 into trunk Nov 24, 2022
@octaedro octaedro deleted the fix/product-management-summary-placeholder-text branch November 24, 2022 20:11
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 24, 2022
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@octaedro octaedro octaedro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AnnaMag AnnaMag

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. Product/Inventory Management Issues related to product or product page.

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

[Enhancement] Adapt the summary text in the product management form.

3 participants

@AnnaMag @octaedro