Skip to content

Fix the gap in the featured product checkbox #35710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
octaedro merged 2 commits into from
Nov 24, 2022
Merged

Fix the gap in the featured product checkbox #35710

octaedro merged 2 commits into from
Nov 24, 2022

Conversation

@octaedro
Copy link
Contributor

@octaedro octaedro commented Nov 24, 2022

All Submissions:

Changes proposed in this Pull Request:

This PR removes the gap between the text and the icon (?) in the featured product checkbox.

Before
Screenshot 2022-11-24 at 09 50 22

After
Screenshot 2022-11-24 at 09 49 58

Closes #35572.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Go to Products > Add New (MVP) > Product details.
  2. Verify that the gap between the icon and the text is 8px.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 24, 2022
@octaedro octaedro self-assigned this Nov 24, 2022
@octaedro octaedro added Enhancement The issue is a request for an enhancement. focus: product management labels Nov 24, 2022
@octaedro octaedro requested a review from a team November 24, 2022 12:54
@octaedro octaedro marked this pull request as ready for review November 24, 2022 12:55
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

Test Results Summary

Commit SHA: 38b7053

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 7s
E2E Tests186006019218m 8s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

mdperez86
mdperez86 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks well.

@octaedro octaedro merged commit 28f5616 into trunk Nov 24, 2022
@octaedro octaedro deleted the fix/35572_gap_in_featured_product_checkbox branch November 24, 2022 15:15
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 24, 2022
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdperez86 mdperez86 mdperez86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@octaedro octaedro

Labels

Enhancement The issue is a request for an enhancement. plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Fix the gap in the featured product checkbox

3 participants

@octaedro @mdperez86