Skip to content

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Nov 23, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #35568

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Go to Products -> Add New (MVP) page
  2. Under Attributes section click on Add first attribute button
  3. The Add attributes modal should be shown.
  4. By default if you don't select any attribute under the attribute search field then the attribute value field should be disabled and with 50% of opacity.
  5. After selecting an attribute from the search field the value field should become enable and with it's normal colors.

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@mdperez86 mdperez86 self-assigned this Nov 23, 2022
@mdperez86 mdperez86 requested a review from octaedro November 23, 2022 20:57
@github-actions github-actions bot added the package: @woocommerce/components issues related to @woocommerce/components label Nov 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2022

Test Results Summary

Commit SHA: f0d3f5b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 55s
E2E Tests186006019214m 32s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @mdperez86! This is testing well and the code LGTM 🚢

@mdperez86 mdperez86 merged commit 3ff334b into trunk Nov 24, 2022
@mdperez86 mdperez86 deleted the enhancement/35568 branch November 24, 2022 17:32
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/components issues related to @woocommerce/components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Fade the value selection field in the Attributes modal when no attribute is added

3 participants