Add/35300 ces feedback product mvp #35690

louwie17 · 2022-11-23T13:48:32Z

All Submissions:

Have you followed the WooCommerce Contributing guideline?
Does your code follow the WordPress' coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Hook in the CES modal to the share feedback button in the new product MVP
Closes #35300 .

This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

Load this branch, build it, and make sure you have the new-product-management-experience feature flag enabled (you can do so using the latest version of the Beta tester within the mono repo).
Make sure you have tracks enabled and also outputted in the console: localStorage.setItem( 'debug', 'wc-admin:*' );
Go to Products > Add New (MVP)
In the top right click the 3 dots and click the Share feedback button
This should show the CES modal asking How's your experience with the product editor?
Answer it with your console open, this should trigger a ces_feedback track with the new_product action.
Now check if the CES footer still works by making sure the woocommerce_ces_product_mvp_ces_action option is removed
Save a product which should show the CES footer bar and click the Share feedback this should still correctly show the CES modal.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

github-actions · 2022-11-23T13:58:10Z

Test Results Summary

Commit SHA: fac751e

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 54s
E2E Tests	186	0	0	6	0	192	14m 46s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

joelclimbsthings · 2022-11-30T02:21:22Z

...commerce-admin/client/customer-effort-score-tracks/customer-effort-score-modal-container.tsx

+			( getOption( ADMIN_INSTALL_TIMESTAMP_OPTION_NAME ) as number ) || 0;
+
+		const resolving =
+			adminInstallTimestamp === null ||


Is adminInstallTimestamp ever null? Just curious since you're casting it as a number TS style just above.

joelclimbsthings

Nice work @louwie17 ! Love centralizing some of this logic in the data store. Could we also implement that approach in the completed-header component?

I left a few minor comments, and a couple regarding needing to update some of the CES data to support the additional question changes merged earlier after a rebase.

joelclimbsthings · 2022-11-30T02:23:10Z

...commerce-admin/client/customer-effort-score-tracks/customer-effort-score-modal-container.tsx

+
+		const resolving =
+			adminInstallTimestamp === null ||
+			isResolving( 'getOption', [ ADMIN_INSTALL_TIMESTAMP_OPTION_NAME ] );


I tend to think hasFinishedResolution is more reliable than isResolving here, since isResolving will briefly be false initially, but perhaps it's working well enough in this context?

joelclimbsthings · 2022-11-30T02:24:18Z

...commerce-admin/client/customer-effort-score-tracks/customer-effort-score-modal-container.tsx

+
+	return (
+		<CustomerFeedbackModal
+			label={ visibleCESModalData.label }


If you rebase on trunk this will need to be updated to include title instead of label, as well as firstQuestion and secondQuestion.

joelclimbsthings · 2022-11-30T02:27:29Z

...commerce-admin/client/customer-effort-score-tracks/customer-effort-score-modal-container.tsx

+
+	const recordScore = ( score: number, comments: string ) => {
+		recordEvent( 'ces_feedback', {
+			action: visibleCESModalData.action,


This also need to be updated to include the score for both questions, and score_combined.

joelclimbsthings · 2022-11-30T02:30:27Z

...commerce-admin/client/customer-effort-score-tracks/customer-effort-score-modal-container.tsx

+				),
+			visibleCESModalData.onSubmitNoticeProps || {}
+		);
+		hideCesModal();


Nitpicky, but it feels like the hideCesModal() call shouldn't reside in the recordScore() function since it's not part of recording the score. Could throw it into an arrow function under the recordScoreCallback prop below.

joelclimbsthings · 2022-11-30T02:31:28Z

plugins/woocommerce-admin/client/customer-effort-score-tracks/data/reducer.js

+				cesModalData: undefined,
+			};
+		case TYPES.SHOW_CES_MODAL:
+			const cesModalData = {


This as well as the other data store calls will need to be updated as outlined in other comments.

joelclimbsthings · 2022-12-01T21:29:52Z

plugins/woocommerce-admin/client/customer-effort-score-tracks/data/actions.js

+ * @param {Object} props               object for optional props
+ * @param {Object} onSubmitNoticeProps object for on submit notice props.
+ */
+export function showCesModal(


Since this function is accepting a number of arguments, some of which could be undefined, perhaps we should have this accept an object with optional properties instead?

export function showCesModal( { action, label, onsubmitLabel = undefined, props = {}, onSubmitNoticeProps = {} } ) { return {

louwie17 · 2022-12-02T10:49:33Z

Thanks for the review @joelclimbsthings, I believe I have addressed all your suggestions.

Could we also implement that approach in the completed-header component?

Yeah we certainly could, but I think it be a bit out of scope for this PR, I could certainly create a separate PR though once this is merged.

joelclimbsthings

Thanks @louwie17 , it's working well!

github-actions bot added the focus: react admin label Nov 23, 2022

louwie17 requested a review from a team November 23, 2022 13:48

louwie17 force-pushed the add/35129_product_mvp_ces branch 2 times, most recently from be6f3fc to 3952fbc Compare November 24, 2022 08:49

louwie17 force-pushed the add/35300_ces_feedback_product_mvp branch from 9e77e69 to 348e00c Compare November 24, 2022 09:08

AnnaMag added the focus: customer effort score label Nov 25, 2022

louwie17 self-assigned this Nov 29, 2022

joelclimbsthings linked an issue Nov 30, 2022 that may be closed by this pull request

CES: Add the feedback button to the navbar only on product MVP #35300

Closed

joelclimbsthings requested review from joelclimbsthings and removed request for a team November 30, 2022 01:57

joelclimbsthings reviewed Nov 30, 2022

View reviewed changes

joelclimbsthings suggested changes Nov 30, 2022

View reviewed changes

louwie17 force-pushed the add/35129_product_mvp_ces branch from 3952fbc to 4b5869f Compare November 30, 2022 11:39

joelclimbsthings mentioned this pull request Nov 30, 2022

CES: Add prompt with spotlight after 7 minutes to create product #35301

Closed

joelclimbsthings reviewed Dec 1, 2022

View reviewed changes

Base automatically changed from add/35129_product_mvp_ces to trunk December 2, 2022 09:35

louwie17 added 5 commits December 2, 2022 11:17

Add ability to show CES modal through share Feedback button

aadbea3

Make use of showCesModal in footer

81bc52a

Update CES action for share feedback

f0a1e6e

Update changes to support second CES question

ae7e0da

Add changelog

e44dc68

louwie17 force-pushed the add/35300_ces_feedback_product_mvp branch from ccfe5fd to e44dc68 Compare December 2, 2022 10:32

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Dec 2, 2022

Address some PR feedback

fac751e

louwie17 requested a review from joelclimbsthings December 2, 2022 10:50

joelclimbsthings approved these changes Dec 2, 2022

View reviewed changes

louwie17 merged commit e7dd1a0 into trunk Dec 2, 2022

louwie17 deleted the add/35300_ces_feedback_product_mvp branch December 2, 2022 15:59

github-actions bot added this to the 7.3.0 milestone Dec 2, 2022

github-actions bot mentioned this pull request Jan 13, 2023

Test WooCommerce 7.3 UVLabs/location-picker-at-checkout-for-woocommerce#59

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add/35300 ces feedback product mvp #35690

Add/35300 ces feedback product mvp #35690

Uh oh!

louwie17 commented Nov 23, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Nov 23, 2022 •

edited

Loading

Uh oh!

joelclimbsthings Nov 30, 2022

Uh oh!

joelclimbsthings left a comment

Uh oh!

joelclimbsthings Nov 30, 2022

Uh oh!

joelclimbsthings Nov 30, 2022

Uh oh!

joelclimbsthings Nov 30, 2022

Uh oh!

joelclimbsthings Nov 30, 2022

Uh oh!

joelclimbsthings Nov 30, 2022

Uh oh!

joelclimbsthings Dec 1, 2022

Uh oh!

louwie17 commented Dec 2, 2022

Uh oh!

joelclimbsthings left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add/35300 ces feedback product mvp #35690

Add/35300 ces feedback product mvp #35690

Uh oh!

Conversation

louwie17 commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

FOR PR REVIEWER ONLY:

Uh oh!

github-actions bot commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary

Uh oh!

joelclimbsthings Nov 30, 2022

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings left a comment

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings Nov 30, 2022

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings Nov 30, 2022

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings Nov 30, 2022

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings Nov 30, 2022

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings Nov 30, 2022

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings Dec 1, 2022

Choose a reason for hiding this comment

Uh oh!

louwie17 commented Dec 2, 2022

Uh oh!

joelclimbsthings left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

louwie17 commented Nov 23, 2022 •

edited

Loading

github-actions bot commented Nov 23, 2022 •

edited

Loading