Add Denmark postcode validation #35653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
The PR adds Denmark postcode validation according to https://en.wikipedia.org/wiki/Postal_codes_in_Denmark. Essentially it's a minor modification of https://rgxdb.com/r/335G4K1S with an optional DB prefix.
As the Denmark postcode can contain
DK-prefix I restored it in thewc_format_postcodefunction (as I can seeLVhas already).Regarding the unit tests, I was a bit confused because the current
\WC_Validation::is_postcodetests are included just in\WC_Tests_Validation::data_provider_test_is_postcodemethod. It should not be touched according toREADME.md. Should I add a new testing class toplugins/woocommerce/tests/php/includes?How to test the changes in this Pull Request:
DK-3900).1448orDK-1448).Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: