Skip to content

Analytics: Fix advanced filtering date selection in WordPress 6.1. #35644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattsherman merged 2 commits into from
Nov 22, 2022
Merged

Analytics: Fix advanced filtering date selection in WordPress 6.1. #35644

mattsherman merged 2 commits into from
Nov 22, 2022

Conversation

@mattsherman
Copy link
Contributor

@mattsherman mattsherman commented Nov 19, 2022

All Submissions:

Changes proposed in this Pull Request:

This PR fixes the advanced date filter used on the WCPay Transactions and Disputes page to work when running on WordPress 6.1.

Closes #35630.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Install WCPay and use the Date filter on the Transactions or Disputes pages.
  2. Select a date.
  3. Click again on the date picker. Verify there is no error, and that date selection works properly.
  4. Activate the filter and verify that the selected dates for the filter are applied properly.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@mattsherman mattsherman added Bug The issue is a confirmed bug. package: @woocommerce/components issues related to @woocommerce/components Reports/Analytics Issues related to analytics section. focus: components labels Nov 19, 2022
@mattsherman mattsherman self-assigned this Nov 19, 2022
@mattsherman mattsherman changed the title Analytics: Fixed date filter date selection in WordPress 6.1. Analytics: Fix date filter date selection in WordPress 6.1. Nov 19, 2022
@mattsherman mattsherman changed the title Analytics: Fix date filter date selection in WordPress 6.1. Analytics: Fix advanced filtering date selection in WordPress 6.1. Nov 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2022 •
edited
Loading

Test Results Summary

Commit SHA: c00fc3c

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26000202621m 0s
E2E Tests186006019219m 2s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman marked this pull request as ready for review November 19, 2022 06:27
@mattsherman
Copy link
Contributor Author

mattsherman commented Nov 19, 2022

@alefesouza Since you found #35630 originally, could you please test and review this?

I managed to get a semi-broken WCPay installation going on my dev env, which got me far enough to be able to test the advanced filter's date pickers on the Transactions screen, but I can't add orders to actually verify that the filtering is working.

@mattsherman mattsherman requested a review from a team November 20, 2022 21:50
@samueljseay samueljseay added this to the 7.2.0 milestone Nov 21, 2022
alefesouza
alefesouza approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@alefesouza alefesouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

louwie17
louwie17 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @mattsherman this tested well on both WP 6.0 and 6.1

@mattsherman mattsherman merged commit 995b587 into trunk Nov 22, 2022
@mattsherman mattsherman deleted the fix/datepicker-moment branch November 22, 2022 14:53
@github-actions github-actions bot mentioned this pull request Nov 22, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Nov 22, 2022
@mattsherman
Analytics: Fix advanced filtering date selection in WordPress 6.1. (#…
d3b05e0 
…35644)

* Fixed date filter date selection in WordPress 6.1.

* Move fix deeper into DatePicker itself.
samueljseay pushed a commit that referenced this pull request Nov 22, 2022
@github-actions @mattsherman
Cherry pick 35644 into release/7.2 (#35674)
0051099 
Analytics: Fix advanced filtering date selection in WordPress 6.1. (#35644)

Co-authored-by: Matt Sherman <[email protected]>
@alefesouza alefesouza mentioned this pull request Nov 24, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alefesouza alefesouza alefesouza approved these changes

@louwie17 louwie17 louwie17 approved these changes

Assignees

@mattsherman mattsherman

Labels

Bug The issue is a confirmed bug. package: @woocommerce/components issues related to @woocommerce/components Reports/Analytics Issues related to analytics section.

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

Analytics/WCPay: Advanced filtering date selection does not work on WordPress 6.1

5 participants

@mattsherman @alefesouza @louwie17 @samueljseay