Add responsiveness to product form header #35623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: react admin
package: @woocommerce/components
joshuatf
force-pushed
the
update/35168
branch
from
e57b454 to
8648857
Compare
github-actions
bot
removed
package: @woocommerce/components
joshuatf
commented
Nov 18, 2022
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore No types for this exist yet. | ||
| // eslint-disable-next-line @woocommerce/dependency-group | ||
| import { store } from '@wordpress/viewport'; |
Contributor
Author
There was a problem hiding this comment.
I tried to add types to this, but the dependency did not work as expected. Worth sanity checking to make sure it's not just my environment.
| const SecondaryActionsComponent = isSmallViewport ? MenuItem : Button; | ||
| const secondaryActions = ( | ||
| <> | ||
| <SecondaryActionsComponent |
Contributor
Author
There was a problem hiding this comment.
No changes in this code other than the SecondaryActionsComponent swapping that occurs.
Contributor
Test Results SummaryCommit SHA: 88c14e2
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
github-actions
bot
added
the
plugin: woocommerce
1 task
mdperez86
reviewed
Nov 24, 2022
Contributor
mdperez86
left a comment
mdperez86
left a comment
There was a problem hiding this comment.
You have some conflicts here. But anithing else works well. Great job!
mdperez86
force-pushed
the
update/35168
branch
from
345dac8 to
88c14e2
Compare
mdperez86
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes up the product form header on smaller screens and move some secondary buttons into the menu group.
Closes #35168 .
How to test the changes in this Pull Request:
Products -> Add new (MVP)Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: