-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add support for the Product by attribute template
#35617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results SummaryCommit SHA: 674bd45
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
f969822 to
038669c
Compare
038669c to
07e71e8
Compare
Product by attribute template
Aljullu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great, thanks @albarin!
I'm approving on behalf of Woo FSE, but we will need somebody from Proton to approve this PR as well.
barryhughes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good: couple of questions I wanted to check in on, but beyond that I think this is good to go.
barryhughes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
All Submissions:
Changes proposed in this Pull Request:
The goal of this PR is to add support for the
Product by attributetemplate. It's related to this task and this PR inwoocommerce-blocks: woocommerce/woocommerce-blocks#7660.How to test the changes in this Pull Request:
Non-FSE theme
Storefronttheme (or any non-FSE theme)./wp-admin/edit.php?post_type=product&page=product_attributesthat you have an attribute with theEnable archive?option checked. Otherwise, create one./wp-admin/edit.php?post_type=product&page=product_attributesaccess the attribute terms by clicking onConfigure terms.Viewoption under your term to go to the frontend page of the attribute, you should see the default template loaded.taxonomy-product_attribute.phpand add some identifiable content. Save the file.taxonomy-product_attribute.phptemplate file you added to the theme.FSE theme
trunkversion ofwoocommerce-blocks(since the work on this PR is also needed Create theProducts by Attributetemplate woocommerce-blocks#7660)TT2theme (or any other FSE theme)./wp-admin/edit.php?post_type=product&page=product_attributesthat you have an attribute with theEnable archive?option checked. Otherwise, create one./wp-admin/edit.php?post_type=product&page=product_attributesaccess the attribute terms by clicking onConfigure terms.Viewoption under your term to go to the frontend page of the attribute, you should see the default template loaded.templatesfolder of your theme calledtaxonomy-product_attribute.htmland add some identifiable content. Save the file.taxonomy-product_attribute.htmltemplate file you added to the theme.Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: