-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Deploy the stacked layout in the Products Task experiment #35611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results SummaryCommit SHA: 61d7ea8
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
ilyasfoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well, thanks for working on this @adrianduffell!
I have a minor comment for removing import { loadExperimentAssignment } from '@woocommerce/explat'; import, but that's nitpicky. Feel free to merge!
ilyasfoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ![]()
moon0326
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
All Submissions:
Changes proposed in this Pull Request:
Deploys the stacked layout in the Products Task experiment.
This is a quick change in time for the 7.2 code freeze to deploy the stacked layout in the Products Task experiment by always returning it as the chosen layout. A follow-up PR will be made to cleanup the experiment code completely.
How to test the changes in this Pull Request:
On a new install,
Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: