Skip to content

Fix styling of CES modal #35602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louwie17 merged 7 commits into from
Nov 18, 2022
Merged

Fix styling of CES modal #35602

louwie17 merged 7 commits into from
Nov 18, 2022

Conversation

@louwie17
Copy link
Contributor

@louwie17 louwie17 commented Nov 16, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

CSS fix for the CES modal only caused in Wordpress version 6.1 and above

Needed for #35129 .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

Test the below steps using Wordpress 6.0.3 and 6.1 seperately.

  1. Load this branch, build it, and make sure you have the new-product-management-experience feature flag enabled (you can do so using the latest version of the Beta tester within the mono repo).
  2. Create a couple products
  3. Go to Analytics > Products
  4. Select Comparison from the Show dropdown
  5. Select a couple products and click Compare
  6. A notice should show up that allows you to share feedback, click this.
  7. Make sure the emoji's show up correctly in a horizontal format.
  8. Note: that this notice will probably only show up once, once you click Share feedback, in order for it to show again you can delete the woocommerce_ces_shown_for_actions option.

Testing bonus points:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin package: @woocommerce/customer-effort-score issues related to @woocommerce/customer-effort-score plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022 •
edited
Loading

Test Results Summary

Commit SHA: b7fd09c

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26000202621m 15s
E2E Tests186006019214m 22s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@louwie17 louwie17 marked this pull request as ready for review November 16, 2022 13:56
@louwie17 louwie17 requested a review from a team November 16, 2022 13:56
@louwie17 louwie17 force-pushed the add/35129_ces_prompt_new_product_mvp branch from f7c5b71 to b7fd09c Compare November 17, 2022 12:34
@github-actions github-actions bot removed focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 17, 2022
@louwie17 louwie17 changed the title Add/35129 ces prompt new product mvp Fix styling of CES modal Nov 17, 2022
mdperez86
mdperez86 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for me.

@joelclimbsthings joelclimbsthings mentioned this pull request Nov 18, 2022
Closed
5 tasks
@louwie17 louwie17 merged commit 6e90fb3 into trunk Nov 18, 2022
@louwie17 louwie17 deleted the add/35129_ces_prompt_new_product_mvp branch November 18, 2022 17:54
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 18, 2022
@samueljseay samueljseay modified the milestones: 7.3.0, 7.2.0 Nov 21, 2022
@github-actions github-actions bot mentioned this pull request Nov 21, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Nov 21, 2022
@louwie17
Fix styling of CES modal (#35602)
750c1d7 
* Add CES notice upon product creation/update

* Remove removal of icon

* Add changelog

* Add customer-effort-score library changelog

* Remove the cesTracks addition for now.

* Fix and add tests

* Revert CES notice changes as styling for this will change
@joelclimbsthings joelclimbsthings mentioned this pull request Nov 22, 2022
Closed
7 tasks
samueljseay pushed a commit that referenced this pull request Nov 22, 2022
@github-actions @louwie17
Cherry pick 35602 into release/7.2 (#35662)
74e32c1 
Fix styling of CES modal (#35602)

Co-authored-by: louwie17 <[email protected]>
@AnnaMag AnnaMag mentioned this pull request Dec 14, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdperez86 mdperez86 mdperez86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: @woocommerce/customer-effort-score issues related to @woocommerce/customer-effort-score

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@louwie17 @mdperez86 @samueljseay