Skip to content

Conversation

@joshuatf
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Adds the product settings menu to the header of the new product management experience.

Screen Shot 2022-11-05 at 11 56 48 AM

Closes #35175 .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Navigate to the new product management experience ( Products -> Add new (MVP) )
  2. Click on the Settings cog icon in the top right inside the header.
  3. Note the menu opens with the option to enable reviews and update menu order
  4. Toggle the “Advanced” section to make sure that it opens and closes as expected
  5. Attempt to close the settings menu with both the cross (“x”) and the settings cog button.
  6. Check that “Enable reviews” is checked by default on new products
  7. Update the “Enable reviews” and “Menu order” settings and update or publish the product
  8. Refresh the page and make sure that your settings persist.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team November 15, 2022 14:22
@joshuatf joshuatf self-assigned this Nov 15, 2022
@github-actions github-actions bot added focus: react admin package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 15, 2022
regular_price: string;
rating_count: number;
related_ids: number[];
reviews_allowed: boolean;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the larger diff here. This (reviews_allowed) was the only added item.

The remaining were alphabetized to make it a bit faster to find items.

@github-actions
Copy link
Contributor

New hook, template, or database changes in this PR

Template changes:

  • File: /plugins/woocommerce/templates/global/form-login.php
    • NOTICE: Version bump found

@github-actions github-actions bot added the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Nov 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

Test Results Summary

Commit SHA: a56d29f

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26000202620m 47s
E2E Tests186006019212m 43s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Base automatically changed from update/35172 to trunk November 15, 2022 19:20
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested good. Nice job!!!

@joshuatf joshuatf merged commit 233e237 into trunk Nov 17, 2022
@joshuatf joshuatf deleted the add/35175 branch November 17, 2022 17:59
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. release: highlight Issues that have a high user impact and need to be discussed/paid attention to.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Header] Contextual action buttons – Settings

3 participants