FSE: Fix icon fonts not being loaded in the Site Editor #35532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Contributor
Test Results SummaryCommit SHA: b96ed61
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Aljullu
reviewed
Nov 10, 2022
Contributor
Aljullu
left a comment
Aljullu
left a comment
There was a problem hiding this comment.
Confirming it fixes the issue. Thanks for investigating this, @danieldudzic!
I have only one small concern: if you have a classic theme active (ie: Storefront) and create a post, you will see woocommerce-blocktheme.css is loaded in the editor, which I think is undesirable. I left a comment below of how I think this could be solved.
Aljullu
approved these changes
Nov 10, 2022
Contributor
Aljullu
left a comment
Aljullu
left a comment
There was a problem hiding this comment.
Thanks for updating this PR, @danieldudzic! LGTM, but I will tag somebody from Proton to take a second look given that it's a PR in WC core.
Aljullu
requested review from
a team and
barryhughes
and removed request for
a team
barryhughes
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
WooCommerce loads icon fonts on the frontend, but doesn't in FSE, resulting in broken icons in the Site Editor. This PR ensures the fonts get loaded in the Site Editor.
Closes #35495
How to test the changes in this Pull Request:
Screenshots
Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: