Skip to content

Conversation

@Konamiman
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Hide the state selector for addresses in Ethiopia and Rwanda.

This pull request replaces #28796 and #28795 (see #28795 (comment)).

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

Try to make a purchase with a shipping address in Ethiopia, verify that you don't see a state selector and that you can place the order. Repeat with Rwanda.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@Konamiman Konamiman self-assigned this Nov 3, 2022
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Nov 3, 2022
@Konamiman Konamiman requested review from a team and vedanshujain and removed request for a team November 3, 2022 11:58
This was referenced Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Test Results Summary

Commit SHA: bbb6923

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 49s
E2E Tests1880010019817m 21s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@samueljseay samueljseay added focus: i18n The issue/PR is related to internationalization. needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. labels May 4, 2023
@samueljseay samueljseay requested a review from a team May 4, 2023 07:39
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Hi @vedanshujain, @woocommerce/proton

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@rrennick rrennick removed the needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. label May 10, 2023
Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Konamiman Konamiman merged commit eccff55 into trunk May 11, 2023
@Konamiman Konamiman deleted the hide_state_from_ethiopia_and_rwanda branch May 11, 2023 09:05
@github-actions github-actions bot added this to the 7.8.0 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

focus: i18n The issue/PR is related to internationalization. plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants