Skip to content

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Oct 31, 2022

All Submissions:

Changes proposed in this Pull Request:

Adds the product form's more menu and several links.

Note that the CES modal still needs to be completed before it can be hooked up to this component.

Screen Shot 2022-11-01 at 10 42 09 AM

Closes #35177 .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Navigate to the new product management experience ( Add new (MVP) )
  2. Click the "more" (vertical ellipsis) button in the top right of the header
  3. Note that each of the links closes the menu
  4. Note that clicking "Use the classic editor" takes you to the classic editing experience
  5. Navigate back to the new experience and publish a product
  6. Click again on "Use the classic editor"
  7. Note that you are taken to the classic editor for the respective published product

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team October 31, 2022 23:51
@joshuatf joshuatf self-assigned this Oct 31, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Test Results Summary

Commit SHA: 6e8ab96

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26000202620m 51s
E2E Tests186006019213m 11s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, and code looks good, just left a similar comment as #35431 in relation to the registerPlugin call.

);
};

registerPlugin( 'woocommerce-product-more-menu', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the this comment #35431 (comment) in the product title PR, I don't think this is necessary.

Base automatically changed from update/35172 to trunk November 15, 2022 19:19
@joshuatf
Copy link
Contributor Author

Thanks for the review @louwie17! I've rebased this after the product title PR merge and removed the unnecessary plugin registration call. 😄

Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 thanks for the rebase and registerPlugin update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Header] Contextual action buttons – More menu

3 participants