-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add contextual product more menu #35447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results SummaryCommit SHA: 6e8ab96
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
louwie17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well, and code looks good, just left a similar comment as #35431 in relation to the registerPlugin call.
| ); | ||
| }; | ||
|
|
||
| registerPlugin( 'woocommerce-product-more-menu', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the this comment #35431 (comment) in the product title PR, I don't think this is necessary.
068ecab to
236c53e
Compare
|
Thanks for the review @louwie17! I've rebased this after the product title PR merge and removed the unnecessary plugin registration call. 😄 |
louwie17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 thanks for the rebase and registerPlugin update.
All Submissions:
Changes proposed in this Pull Request:
Adds the product form's more menu and several links.
Note that the CES modal still needs to be completed before it can be hooked up to this component.
Closes #35177 .
How to test the changes in this Pull Request:
Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: