-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Fix invalid wcadmin_install_plugin_error event props
#35411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results SummaryCommit SHA: 28bcf9b
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
03cc1f0 to
28bcf9b
Compare
ilyasfoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well! I've confirmed both tracks are recorded without reject in backend. I dont think this requires another review, LGTM!
| ); | ||
| wc_admin_record_tracks_event( 'install_plugin_error', $properties ); | ||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these comments!
|
Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
All Submissions:
Changes proposed in this Pull Request:
Closes 103-gh-woocommerce/team-ghidorah.
Instead of passing the objects, this PR change to pass strings to tracks. Besides, I also fixed the
error_messagetranslation string and docblock lint issues.How to test the changes in this Pull Request:
Code Snippetsand woocommerce-beta-testerwcadmin_install_plugin_errorstringOther information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: