Skip to content

Conversation

@Babylon1999
Copy link
Contributor

@Babylon1999 Babylon1999 commented Oct 28, 2022

All Submissions:

Changes proposed in this Pull Request:

The Libyan Dinar is formatted like this ل.د which is wrong, it's like saying Dollar US or Lira Turkish.

The correct format is د.ل, I went ahead and switched the characters in the following templates.

The problem was reported in this thread a P2 was also made in woohcp2.

Closes # .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Visit WooCommerce ‣ Settings ‣ General.
  2. The symbol for Libyan Dinars (in the currency selector) should render as د.ل (previously, it was reversed).
  3. If you select this currency and look at the storefront, you should see the same thing there.

libyan-dinar

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Oct 28, 2022
@woocommercebot woocommercebot requested review from a team and barryhughes and removed request for a team October 28, 2022 19:18
Babylon1999 and others added 3 commits October 31, 2022 13:00
Switching the Libyan Dinar symbol.
Changing the symbol of the Libyan Dinar.
@barryhughes
Copy link
Member

The failing API test seems to relate to this change; we'll need to look into that in a little more detail before proceeding.

@barryhughes barryhughes merged commit 3df6dcd into woocommerce:trunk Nov 3, 2022
@github-actions github-actions bot added this to the 7.2.0 milestone Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@Babylon1999
Copy link
Contributor Author

Thank you so much @barryhughes! 🤗

@barryhughes
Copy link
Member

You're welcome - thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants