Skip to content

Conversation

@joshuatf
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Part of #34930

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Visit the homepage with from_calypso appended to the URL. wp-admin/admin.php?page=wc-admin&from_calypso=1
  2. Install a plugin like WP Crontrol
  3. Under Tools -> Cron Events, run wc_admin_daily
  4. Make sure the note with a title of "Welcome to your new store management experience" has not been added

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team October 26, 2022 22:29
@joshuatf joshuatf self-assigned this Oct 26, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022

Test Results Summary

Commit SHA: 61e2255

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26000202620m 55s
E2E Tests186006019214m 29s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@joshuatf joshuatf mentioned this pull request Oct 31, 2022
17 tasks
@joshuatf joshuatf force-pushed the remove/welcome-to-woocommerce-for-store-users-note branch from 70f50f3 to 7828c0a Compare November 1, 2022 18:51
@joelclimbsthings joelclimbsthings requested review from joelclimbsthings and removed request for a team November 2, 2022 19:38
Copy link
Contributor

@joelclimbsthings joelclimbsthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshuatf , code looks good and no sign of the note after running through the steps 🚢

@joshuatf joshuatf force-pushed the remove/welcome-to-woocommerce-for-store-users-note branch from 7828c0a to 471d9ee Compare November 3, 2022 19:30
@joshuatf joshuatf force-pushed the remove/welcome-to-woocommerce-for-store-users-note branch from 471d9ee to 61e2255 Compare November 16, 2022 15:02
@joshuatf joshuatf merged commit 6f7cc70 into trunk Nov 18, 2022
@joshuatf joshuatf deleted the remove/welcome-to-woocommerce-for-store-users-note branch November 18, 2022 17:51
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants