Skip to content

Remove update store details note #35322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshuatf merged 4 commits into from
Nov 3, 2022
Merged

Remove update store details note #35322

joshuatf merged 4 commits into from
Nov 3, 2022

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Oct 25, 2022

All Submissions:

Changes proposed in this Pull Request:

Remove the update store details note

Closes #34930 .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. On a new site, do not complete the onboarding profiler and do not check the checkbox for "Setup for client" during onboarding
  2. Install a plugin like WP Crontrol
  3. Under Tools -> Cron Events, run wc_admin_daily
  4. Make sure the note with a title of "Edit your store details if you need to" has not been added

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team October 25, 2022 23:55
@joshuatf joshuatf self-assigned this Oct 25, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 25, 2022
joshuatf
joshuatf commented Oct 25, 2022
View reviewed changes
plugins/woocommerce/tests/legacy/unit-tests/woocommerce-admin/api/admin-notes.php
*
* @since 3.5.0
*/
public function test_getting_notes_when_user_is_in_tasklist_experiment_returns_unfiltered_notes() {
Copy link
Contributor Author

@joshuatf joshuatf Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaclync Just want to double check that this experiment is no longer being run and that these tests are safe to remove.

It looks like wc-admin-complete-store-details may have already been removed and this PR will remove wc-admin-update-store-details.

Copy link
Contributor

@jaclync jaclync Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to remove 👍 I searched for the experiment woocommerce_tasklist_progression_headercard in ExPlat and all the experiments are disabled, the last one ended on March 22, 2022. I didn't work on the experiment, if you'd like to double check the experiment owner is pmcpinto.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited
Loading

Test Results Summary

Commit SHA: c9edf6f

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900302620m 51s
E2E Tests186006019214m 14s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@joshuatf joshuatf mentioned this pull request Oct 31, 2022
Closed
17 tasks
@joshuatf joshuatf force-pushed the remove/update-store-details-note branch from 66c7c5d to c9edf6f Compare November 1, 2022 18:49
louwie17
louwie17 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joshuatf joshuatf merged commit a6ed0a0 into trunk Nov 3, 2022
@joshuatf joshuatf deleted the remove/update-store-details-note branch November 3, 2022 16:47
@github-actions github-actions bot added this to the 7.2.0 milestone Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Hi @joshuatf, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync jaclync left review comments

@louwie17 louwie17 louwie17 approved these changes

Assignees

@joshuatf joshuatf

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

Remove low-performing notifications

4 participants

@joshuatf @jaclync @louwie17