Skip to content

Remove manage store activity from home screen note #35320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshuatf merged 3 commits into from
Nov 3, 2022
Merged

Remove manage store activity from home screen note #35320

joshuatf merged 3 commits into from
Nov 3, 2022

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Oct 25, 2022

All Submissions:

Changes proposed in this Pull Request:

Removes the note about managing store activity from the home screen.

Part of #34930

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Install a plugin like WP Crontrol
  2. Under Tools -> Cron Events, run wc_admin_daily
  3. Make sure the note with a title of "New! Manage your store activity from the Home screen" has not been added

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team October 25, 2022 23:37
@joshuatf joshuatf self-assigned this Oct 25, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 46ccaa4

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900302621m 4s
E2E Tests186006019220m 34s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@joshuatf joshuatf mentioned this pull request Oct 31, 2022
Closed
17 tasks
@joshuatf joshuatf force-pushed the remove/manage-store-activity-from-home-screen-note branch from c14dddd to 46ccaa4 Compare November 1, 2022 18:49
@louwie17 louwie17 self-requested a review November 2, 2022 19:24
louwie17
louwie17 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't show, although I couldn't even get this note to show on trunk I get a feeling this note hasn't worked for a while.

@louwie17
Copy link
Contributor

louwie17 commented Nov 2, 2022 •
edited
Loading

This one likely stopped working after the WooCommerce merge, as the update logic would of changed.

@pmcpinto not sure if this is reason for the lack of interactivity, and a reason to fix this note instead of deleting it?

@joshuatf
Copy link
Contributor Author

joshuatf commented Nov 3, 2022

Going to merge and remove for now. @pmcpinto let us know if you'd like to reintroduce.

@joshuatf joshuatf merged commit ad1c49f into trunk Nov 3, 2022
@joshuatf joshuatf deleted the remove/manage-store-activity-from-home-screen-note branch November 3, 2022 19:27
@github-actions github-actions bot added this to the 7.2.0 milestone Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Hi @joshuatf, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

Assignees

@joshuatf joshuatf

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@joshuatf @louwie17