Skip to content

Conversation

@joshuatf
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Remove the first downloadable product note

Part of #34930

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Create at least 1 downloadable product
  2. Install a plugin like WP Crontrol
  3. Under Tools -> Cron Events, run wc_admin_daily
  4. Make sure the note with a title of "Learn more about digital/downloadable products" has not been added

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team October 25, 2022 23:21
@joshuatf joshuatf self-assigned this Oct 25, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Test Results Summary

Commit SHA: 96b1b8b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900302620m 51s
E2E Tests186006019216m 58s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@joshuatf joshuatf mentioned this pull request Oct 31, 2022
17 tasks
@joshuatf joshuatf force-pushed the remove/first-downloadable-product-note branch from b56bf37 to cdb1433 Compare November 1, 2022 18:48
@louwie17 louwie17 self-requested a review November 2, 2022 19:06
louwie17
louwie17 previously approved these changes Nov 2, 2022
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Also tested the fact that it removes the note after update, this seemed to work well, nice work!

@joshuatf joshuatf force-pushed the remove/first-downloadable-product-note branch from cdb1433 to 96b1b8b Compare November 3, 2022 19:23
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rebase, LGTM 🚀

@joshuatf joshuatf merged commit c62f984 into trunk Nov 3, 2022
@joshuatf joshuatf deleted the remove/first-downloadable-product-note branch November 3, 2022 20:13
@github-actions github-actions bot added this to the 7.2.0 milestone Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Hi @joshuatf, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants