Skip to content

Fix the display of letter descenders in the shipping class dropdown menu #35258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdperez86 merged 2 commits into from
Oct 25, 2022
Merged

Fix the display of letter descenders in the shipping class dropdown menu #35258

mdperez86 merged 2 commits into from
Oct 25, 2022

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Oct 21, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #35188.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Go to Add new product page
  2. The Shipping class dropdown should show the selected option correctly displayed with no visible glitches in all browsers.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@mdperez86 mdperez86 added Enhancement The issue is a request for an enhancement. focus: product management labels Oct 21, 2022
@mdperez86 mdperez86 self-assigned this Oct 21, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 21, 2022
@mdperez86 mdperez86 marked this pull request as ready for review October 21, 2022 16:55
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 2e1b4cf

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests21100202130m 54s
E2E Tests186006019218m 51s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

louwie17
louwie17 requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, just left a small suggestion to use normal instead of a specified value.

plugins/woocommerce-admin/client/stylesheets/shared/_global.scss Outdated
.components-base-control select.components-select-control__input {
max-width: 100%;
line-height: 1;
line-height: 1.2rem;
Copy link
Contributor

@louwie17 louwie17 Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should actually use line-height: normal here, this appears to be the same value used for the any of the control input fields, and although it would be very similar to 1.2rem, normal apparently better adheres to the font family being used.

Copy link
Contributor Author

@mdperez86 mdperez86 Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

@mdperez86 mdperez86 force-pushed the enhancement/35188-fix-display-letters branch from 4135a0f to 7853ce6 Compare October 25, 2022 19:55
@mdperez86 mdperez86 requested a review from louwie17 October 25, 2022 19:56
@mdperez86 mdperez86 force-pushed the enhancement/35188-fix-display-letters branch from 1c57f0e to 2e1b4cf Compare October 25, 2022 19:57
louwie17
louwie17 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mdperez86 mdperez86 merged commit 47439ec into trunk Oct 25, 2022
@mdperez86 mdperez86 deleted the enhancement/35188-fix-display-letters branch October 25, 2022 20:28
@github-actions github-actions bot added this to the 7.2.0 milestone Oct 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Hi @mdperez86, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

@octaedro octaedro Awaiting requested review from octaedro

@mattsherman mattsherman Awaiting requested review from mattsherman

Assignees

@mdperez86 mdperez86

Labels

Enhancement The issue is a request for an enhancement. plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Fix the display of letter descenders in the shipping class dropdown menu

3 participants

@mdperez86 @louwie17