Skip to content

Revert change that auto collapses the short description field #35213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louwie17 merged 1 commit into from
Oct 21, 2022
Merged

Revert change that auto collapses the short description field #35213

louwie17 merged 1 commit into from
Oct 21, 2022

Conversation

@louwie17
Copy link
Contributor

@louwie17 louwie17 commented Oct 20, 2022

All Submissions:

Changes proposed in this Pull Request:

This change reverts a change added as part of this issue's requirement originally that auto collapses the product short description (original PR).
From user feedback received, the short description is quite popular and having to expand it each time is more of a time cost instead of saving.

Closes #33537 .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Load this branch, run pnpm run build
  2. Go to Products > Add New or edit an existing product
  3. Scrolld own and check if the Product short description is expanded by default.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@louwie17 louwie17 requested a review from a team October 20, 2022 15:43
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Oct 20, 2022
@louwie17 louwie17 mentioned this pull request Oct 20, 2022
Closed
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

Test Results Summary

Commit SHA: a1ceabb

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests19600201980m 55s
E2E Tests186003018916m 12s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@loulemos
Copy link

loulemos commented Oct 21, 2022

Please revert it.

octaedro
octaedro approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @louwie17 for the quick fix! This is testing well on my end and the code LGTM 🚀

@louwie17 louwie17 merged commit ccae9ac into trunk Oct 21, 2022
@louwie17 louwie17 deleted the fix/33537_revert_closing_short_description_by_default branch October 21, 2022 15:34
@github-actions github-actions bot added this to the 7.2.0 milestone Oct 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

Hi @louwie17, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@rinkrote
Copy link

rinkrote commented Oct 30, 2022

Hi. I'm a new user on github. Where it says the bot "added this to the 7.2 milestone" - does that mean that this will for sure be reverted on the 7.2 release? Also where is the best place to follow for timelines for upcoming releases. The developer.woocommerce.com blog doesn't have any posts about 7.1 nor 7.2 beta/RCs? I'm still trying to figure out navigating github :)

@AnnaMag
Copy link
Contributor

AnnaMag commented Nov 3, 2022 •
edited
Loading

Hi @rinkrote 👋

does that mean that this will for sure be reverted on the 7.2 release

yes.

where is the best place to follow for timelines for upcoming releases

Please check https://developer.woocommerce.com/releases/.

Hope this helps!

@mattsherman mattsherman mentioned this pull request Nov 16, 2022
Closed
5 tasks
@myedgy
Copy link

myedgy commented Dec 7, 2022

Yes please!!!!! Thank you! When will this update come?

@rinkrote
Copy link

rinkrote commented Dec 7, 2022

Yes please!!!!! Thank you! When will this update come?

Looks like (according to https://developer.woocommerce.com/2022/11/29/woocommerce-7-2-beta-2/ ) that 7.2 is scheduled to be released Dec 13th.

@pmcpinto pmcpinto mentioned this pull request Dec 9, 2022
Merged
8 tasks
n7studios added a commit to Kit/convertkit-wordpress that referenced this pull request Dec 14, 2022
@n7studios
Don’t toggle the product short description metabox
c3cc8b5 
WooCommerce 7.2 no longer auto collapses the short description field, so we don’t need to open it.  See woocommerce/woocommerce#35213
@n7studios n7studios mentioned this pull request Dec 14, 2022
Merged
6 tasks
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@octaedro octaedro octaedro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

Product creation experience: no clear distinction between long and short description

7 participants

@louwie17 @loulemos @rinkrote @AnnaMag @myedgy @octaedro