Skip to content

Add summary field to new product experience #35201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshuatf merged 2 commits into from
Oct 26, 2022
Merged

Add summary field to new product experience #35201

joshuatf merged 2 commits into from
Oct 26, 2022

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Oct 19, 2022

All Submissions:

Changes proposed in this Pull Request:

Adds the summary field to the new product page experience.

Closes #35165 .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Visit the new experience (Products-> Add new (MVP))
  2. Add some content to the summary field
  3. Publish the product
  4. Make sure the data persists on refresh

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team October 19, 2022 23:32
@joshuatf joshuatf self-assigned this Oct 19, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2022

Test Results Summary

Commit SHA: 221cf30

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests19600201981m 1s
E2E Tests186003018916m 4s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

louwie17
louwie17 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall tested well, but it appears to be adding an extra empty block after I refresh the page, this feels a bit odd. This also seems to happen with the description field, so I am approving this, but it would be nice to fix that for both of them if possible.

@joshuatf joshuatf merged commit 89961fe into trunk Oct 26, 2022
@joshuatf joshuatf deleted the add/35165 branch October 26, 2022 18:20
@github-actions github-actions bot added this to the 7.2.0 milestone Oct 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022

Hi @joshuatf, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

Assignees

@joshuatf joshuatf

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

Product creation experience: Add product summary

4 participants

@joshuatf @louwie17 @AnnaMag