Skip to content

Conversation

@peterfabian
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Cheery picked the commit from #29844 and created a new PR as the repo structure changed too much, a rebase probably won't work.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Switch to this PR branch.
  2. Verify state list is available on Checkout page after selecting Senegal as shipping destination Country.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Oct 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2022

Test Results Summary

Commit SHA: 1be92ae

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests20300202050m 59s
E2E Tests186006019215m 6s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.

@jorgeatorres jorgeatorres merged commit 4cde06e into trunk Oct 25, 2022
@jorgeatorres jorgeatorres deleted the fix/29844-replay branch October 25, 2022 17:51
@github-actions github-actions bot added this to the 7.2.0 milestone Oct 25, 2022
@github-actions
Copy link
Contributor

Hi @jorgeatorres, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants