Skip to content

Conversation

@rjchow
Copy link
Contributor

@rjchow rjchow commented Oct 13, 2022

All Submissions:

Changes proposed in this Pull Request:

Added error handling for the send magic link status

Note that the snackbar notice is still under the modal overlay, this needs to be fixed either in layout or in the @wordpress/components Guide component so that'll be done in a separate PR

Closes #34796.

How to test the changes in this Pull Request:

(Skip to 4 if you have set up the mobile app magic link feature previously)

  1. Install WooCommerce, skip OBW and do not install Jetpack
  2. Click on the "Get the WooCommerce Mobile App" additional task list item
  3. Go through with connection process
  4. When you click on the "Send Magic Link" button you should see a spinner. Use devtools throttling if its too fast for you 😁
  5. Go back by clicking on send magic link again
  6. Block the URL in your devtools network panel (see screenshot)
  7. You should see the error notice at the bottom of the screen

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 13, 2022
@rjchow rjchow force-pushed the fix/mobile-app-misleading-progress-error branch from 0802422 to e7a3c77 Compare October 13, 2022 06:59
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

Test Results Summary

Commit SHA: e7a3c77

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests18800201900m 45s
E2E Tests186003018916m 28s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rjchow rjchow marked this pull request as ready for review October 13, 2022 07:07
@rjchow rjchow requested a review from a team October 13, 2022 07:07
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM! :shipit:

@rjchow rjchow merged commit 1991347 into trunk Oct 13, 2022
@rjchow rjchow deleted the fix/mobile-app-misleading-progress-error branch October 13, 2022 08:12
@github-actions github-actions bot added this to the 7.1.0 milestone Oct 13, 2022
@github-actions
Copy link
Contributor

Hi @rjchow, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile App Magic Link Feature: premature success message

3 participants