Skip to content

Improve the "Dismiss" button visibility #35060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
octaedro merged 2 commits into from
Oct 13, 2022
Merged

Improve the "Dismiss" button visibility #35060

octaedro merged 2 commits into from
Oct 13, 2022

Conversation

@octaedro
Copy link
Contributor

@octaedro octaedro commented Oct 12, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This PR adds the code to make the Dismiss button in the inbox notifications always visible. It used to be hidden until hovering over the notification.

Screen Capture on 2022-10-12 at 13-37-17

Closes #34928.

How to test the changes in this Pull Request:

  1. Checkout this branch and build the project.
  2. Go to the Home screen and verify the Dismiss button in the inbox notifications is always visible.
  3. Try the buttons and verify that they work correctly.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the package: @woocommerce/experimental issues related to @woocommerce/experimental label Oct 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022 •
edited
Loading

Test Results Summary

Commit SHA: c8c7a23

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests18800201900m 41s
E2E Tests127428014110m 52s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.
  • INCOMPLETE E2E TEST RUN. We have a total of 189 E2E tests, but only 141 were executed. Note that in CI, E2E tests automatically end when they encounter too many failures.
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@octaedro octaedro requested a review from a team October 12, 2022 20:46
@octaedro octaedro marked this pull request as ready for review October 12, 2022 20:46
@octaedro octaedro self-assigned this Oct 12, 2022
@octaedro octaedro added this to the 7.1.0 milestone Oct 12, 2022
@joelclimbsthings joelclimbsthings requested review from joelclimbsthings and removed request for a team October 12, 2022 21:46
joelclimbsthings
joelclimbsthings approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@joelclimbsthings joelclimbsthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works great @octaedro ! 🚢

@octaedro octaedro merged commit ca4bd88 into trunk Oct 13, 2022
@octaedro octaedro deleted the dev/34928_improve_dismiss_button_visibility branch October 13, 2022 12:42
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

Hi @octaedro, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joelclimbsthings joelclimbsthings joelclimbsthings approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@octaedro octaedro

Labels

package: @woocommerce/experimental issues related to @woocommerce/experimental

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

Improve the "Dismiss" button visibility

3 participants

@octaedro @joelclimbsthings