Skip to content

Conversation

@rjchow
Copy link
Contributor

@rjchow rjchow commented Oct 12, 2022

All Submissions:

Changes proposed in this Pull Request:

Add conditions to exclude mismatching Jetpack users from seeing the additional task list item

Closes #34797 .

How to test the changes in this Pull Request:

Same as #34653

  1. Create a new WooCommerce store that can have Jetpack installed and connected
  2. Skip OBW, do not install Jetpack in OBW
  3. Observe that as the admin user you can see the 'Get the free WooCommerce mobile app' additional task list item
  4. Click on it and go through with the entire flow
  5. Create a second admin user
  6. Observe that the second admin user cannot see the task
  7. Non-admins should also not be able to see the task

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 12, 2022
@rjchow rjchow changed the title fix/mismatched jetpack user mobile app Fix: mismatching jetpack user should not see mobile app task list item Oct 12, 2022
@rjchow rjchow marked this pull request as ready for review October 12, 2022 09:54
@rjchow rjchow requested a review from a team October 12, 2022 09:54
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: abbf926

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests18800201900m 58s
E2E Tests186003018912m 14s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rjchow. Tested well and LGTM. 🚢 🚢

@rjchow rjchow merged commit edbb3ea into trunk Oct 13, 2022
@rjchow rjchow deleted the fix/mismatched-jetpack-user-mobile-app branch October 13, 2022 02:27
@github-actions github-actions bot added this to the 7.1.0 milestone Oct 13, 2022
@github-actions
Copy link
Contributor

Hi @rjchow, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile App Magic Link Feature: Mismatched accounts

3 participants