Skip to content

Add manual stock management section to product management experience #35047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshuatf merged 5 commits into from
Oct 20, 2022
Merged

Add manual stock management section to product management experience #35047

joshuatf merged 5 commits into from
Oct 20, 2022

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Oct 12, 2022

All Submissions:

Changes proposed in this Pull Request:

Adds the section to manually manage the stock status.

Closes #34388 .

How to test the changes in this Pull Request:

  1. Navigate to Products -> Add new (MVP)
  2. Toggle off the "Track quantity for this product" setting
  3. Switch between various stock statuses shown
  4. Make sure that the stock statuses persist on refresh
  5. Toggle on the "Track quantity for this product" setting
  6. Make sure the stock statuses are not shown

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team October 12, 2022 00:44
@joshuatf joshuatf self-assigned this Oct 12, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution release: highlight Issues that have a high user impact and need to be discussed/paid attention to. labels Oct 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 2c6c31e

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests19600201980m 59s
E2E Tests186003018914m 13s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Base automatically changed from add/34387 to trunk October 12, 2022 21:30
@github-actions github-actions bot removed the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Oct 17, 2022
@joshuatf joshuatf mentioned this pull request Oct 18, 2022
Merged
8 tasks
mdperez86
mdperez86 reviewed Oct 20, 2022
View reviewed changes
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @joshuatf !!!

I left some small comments around

@joshuatf
Copy link
Contributor Author

joshuatf commented Oct 20, 2022

Hey @mdperez86 - just updated per your feedback. Please take another look when you can.

@joshuatf joshuatf mentioned this pull request Oct 20, 2022
Merged
8 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

New hook, template, or database changes in this PR

New hooks:

  • file: /plugins/woocommerce/src/Internal/Features/FeaturesController.php
    • NOTICE - 'woocommerce_feature_description_tip' introduced in 7.1.0:

@github-actions github-actions bot added the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Oct 20, 2022
@joshuatf joshuatf merged commit 3a2a229 into trunk Oct 20, 2022
@joshuatf joshuatf deleted the add/34388 branch October 20, 2022 21:14
@github-actions github-actions bot added this to the 7.2.0 milestone Oct 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

Hi @joshuatf, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdperez86 mdperez86 mdperez86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joshuatf joshuatf

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. release: highlight Issues that have a high user impact and need to be discussed/paid attention to.

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

[Inventory] Manual inventory management

4 participants

@joshuatf @mdperez86 @psealock