Skip to content

Fix JS errors when the OBW business step is accessed directly via URL #35045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 2 commits into from
Oct 14, 2022
Merged

Fix JS errors when the OBW business step is accessed directly via URL #35045

moon0326 merged 2 commits into from
Oct 14, 2022

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Oct 11, 2022

All Submissions:

Changes proposed in this Pull Request:

Fixed JS errors on the business step page by setting a default value for the product type var.

Other pages worked without any JS error when accessed directly via URL.

Closes #34974

How to test the changes in this Pull Request:

  1. Start with a fresh site.
  2. Access the business directly via http://your-site/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard&step=business-details
  3. Confirm the page renders without any JS errors.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@moon0326 moon0326 requested a review from a team October 11, 2022 23:09
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 92b8237

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests18800201900m 42s
E2E Tests186003018915m 28s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

chihsuan
chihsuan previously approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moon0326 Thanks for the quick fix! Looks good to me. 🚢

I think you'll need to rebase to trunk to merge because the Github GH action has changed in #35012.

@moon0326
Copy link
Contributor Author

moon0326 commented Oct 12, 2022 •
edited
Loading

Thank you! Rebased! Could you give one more approval, please?

P.S: Looks like some tests are failing. I'll wait and see if we get a fix soon. We probably have to rebase again.

@moon0326 moon0326 force-pushed the fix/34974-obw-steps-break-via-url branch from 3e22132 to b7d095e Compare October 12, 2022 19:33
@chihsuan
Copy link
Member

chihsuan commented Oct 13, 2022

Thank you! Rebased! Could you give one more approval, please?

P.S: Looks like some tests are failing. I'll wait and see if we get a fix soon. We probably have to rebase again.

Yup, I'll approve this again once E2E CI is fixed. 🙌

@moon0326 moon0326 force-pushed the fix/34974-obw-steps-break-via-url branch from b7d095e to 92b8237 Compare October 13, 2022 18:55
@moon0326
Copy link
Contributor Author

moon0326 commented Oct 13, 2022

Thank you! Rebased! Could you give one more approval, please?
P.S: Looks like some tests are failing. I'll wait and see if we get a fix soon. We probably have to rebase again.

Yup, I'll approve this again once E2E CI is fixed. 🙌

Could you approve it one more time please? CI is fixed 👍

chihsuan
chihsuan approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@moon0326 moon0326 merged commit 0f58f2e into trunk Oct 14, 2022
@moon0326 moon0326 deleted the fix/34974-obw-steps-break-via-url branch October 14, 2022 18:43
@github-actions github-actions bot added this to the 7.2.0 milestone Oct 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2022

Hi @moon0326, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

WooCommerce Admin Onboarding profiler breaks when skipping steps via URL

3 participants

@moon0326 @chihsuan