Skip to content

Change copy of the payments welcome modal #35031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oaratovskyi merged 3 commits into from
Oct 12, 2022
Merged

Change copy of the payments welcome modal #35031

oaratovskyi merged 3 commits into from
Oct 12, 2022

Conversation

@oaratovskyi
Copy link
Contributor

@oaratovskyi oaratovskyi commented Oct 11, 2022 •
edited by ismaeldcom
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes Automattic/woocommerce-payments#4827.

Updated the copy text in the payments welcome modal according to the P2 comment parYuf-sD-p2#comment-787.

Before
image
After
image (1)

How to test the changes in this Pull Request:

  1. Checkout the branch tweak/wcpay-4827-change-copy-of-the-payments-welcome-modal
  2. Up it locally and visit wp-admin/admin.php?page=wc-admin&path=%2Fwc-pay-welcome-page
  3. Click "No, thanks" and observe the modal is shown.
  4. Check that the new copy is correct.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 11, 2022
@oaratovskyi oaratovskyi marked this pull request as ready for review October 11, 2022 10:15
@oaratovskyi oaratovskyi requested review from a team October 11, 2022 10:15
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 84f0f73

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests18800201900m 52s
E2E Tests186003018913m 4s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

ismaeldcom
ismaeldcom approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@ismaeldcom ismaeldcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it, the copy matches the latest update.

moon0326
moon0326 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes 👍 LGTM!

@oaratovskyi oaratovskyi merged commit a9dbb6d into trunk Oct 12, 2022
@oaratovskyi oaratovskyi deleted the tweak/wcpay-4827-change-copy-of-the-payments-welcome-modal branch October 12, 2022 13:18
@github-actions github-actions bot added this to the 7.1.0 milestone Oct 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022 •
edited by oaratovskyi
Loading

Hi @oaratovskyi, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@oaratovskyi oaratovskyi added the release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] label Oct 12, 2022
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ismaeldcom ismaeldcom ismaeldcom approved these changes

+1 more reviewer

@moon0326 moon0326 moon0326 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto]

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

Modal in WC Core incentive needs to have a more clear copy

4 participants

@oaratovskyi @moon0326 @ismaeldcom