Skip to content

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Oct 6, 2022

All Submissions:

Changes proposed in this Pull Request:

Add in the inventory manage stock section

Screen Shot 2022-10-06 at 4 12 01 PM

Screen Shot 2022-10-06 at 4 11 44 PM

Screen Shot 2022-10-06 at 4 11 39 PM

Closes #34387 .

How to test the changes in this Pull Request:

  1. Toggle site wide stock management at wp-admin/admin.php?page=wc-settings&tab=products&section=inventory
  2. Check on the add new product page experience wp-admin/admin.php?page=wc-admin&path=%2Fadd-product that the inventory manage stock is shown or hidden based on your above selection.
  3. Make sure that toggling Track quantity for this product opens the quantity management
  4. Add negative values to fields to check that form validation errors appear
  5. Check that the placeholder value for EMAIL ME WHEN QUANTITY REACHES matches the "Low stock threshold" quantity in wp-admin/admin.php?page=wc-settings&tab=products&section=inventory
  6. Make sure settings persist upon save

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team October 6, 2022 23:49
@joshuatf joshuatf self-assigned this Oct 6, 2022
@github-actions github-actions bot added focus: react admin package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 6, 2022
@joshuatf joshuatf changed the title Add/34387 Add product page inventory quantity management Oct 6, 2022
@github-actions github-actions bot added the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Test Results Summary

Commit SHA: 58911d2

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests18800201900m 51s
E2E Tests694140787m 29s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.
  • INCOMPLETE E2E TEST RUN. We have a total of 189 E2E tests, but only 78 were executed. Note that in CI, E2E tests automatically end when they encounter too many failures.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

mdperez86
mdperez86 previously approved these changes Oct 7, 2022
@joshuatf joshuatf force-pushed the add/34386 branch 3 times, most recently from 60da981 to 91ef513 Compare October 12, 2022 18:31
Base automatically changed from add/34386 to trunk October 12, 2022 20:11
@github-actions github-actions bot removed the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Oct 12, 2022
@joshuatf joshuatf merged commit 8fbdbaf into trunk Oct 12, 2022
@joshuatf joshuatf deleted the add/34387 branch October 12, 2022 21:30
@github-actions github-actions bot added this to the 7.1.0 milestone Oct 12, 2022
@github-actions
Copy link
Contributor

Hi @joshuatf, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Inventory] Quantity tracking

4 participants