Skip to content

Correct the textarea name in the Product Short Description template. #34936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Konamiman merged 1 commit into from
Oct 5, 2022
Merged

Correct the textarea name in the Product Short Description template. #34936

Konamiman merged 1 commit into from
Oct 5, 2022

Conversation

@barryhughes
Copy link
Member

@barryhughes barryhughes commented Oct 3, 2022

Corrects an error introduced in #34477, in which an admin template used in the product editor was modified, stopping product short descriptions from being saved.

Closes #34925.

How to test the changes in this Pull Request:

  1. Please confirm everything still works as per the testing instructions in Customer Notes for COT #34477 (noting that the wp wc cot migrate command is now wp wc cot sync).
  2. Then, edit a product and modify the short description. Save. The change should persist.

product-short-desc-field

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Oct 3, 2022
@barryhughes barryhughes requested review from a team and Konamiman and removed request for a team October 3, 2022 18:11
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Test Results Summary

Commit SHA: f8981ff

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests12000201220m 49s
E2E Tests187002018915m 12s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@roykho roykho added the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Oct 3, 2022
@roykho roykho added this to the 7.0.0 milestone Oct 3, 2022
@Konamiman Konamiman merged commit bb89859 into trunk Oct 5, 2022
@Konamiman Konamiman deleted the fix/34925-product-short-description branch October 5, 2022 14:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Hi @Konamiman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Oct 5, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
@barryhughes
Correct the textarea name in the Product Short Description template. (#…
49ea9a9 
…34936)
@github-actions github-actions bot mentioned this pull request Oct 5, 2022
Merged
roykho pushed a commit that referenced this pull request Oct 5, 2022
@github-actions @barryhughes
Cherry pick 34936 into release/7.0 (#34957)
89596fd 
* Correct the textarea name in the Product Short Description template. (#34936)

* Prep for cherry pick 34936

Co-authored-by: Barry Hughes <[email protected]>
Co-authored-by: WooCommerce Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Konamiman Konamiman Konamiman approved these changes

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. release: cherry-pick Commits from this PR also needs to be added to current release branch.

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[7.0 RC] Product short description fails to save or update

4 participants

@barryhughes @Konamiman @roykho