Fix: can't place orders for Saint Martin #34920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Contributor
Test Results SummaryCommit SHA: 780b14a
To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
peterfabian
approved these changes
Oct 3, 2022
Contributor
peterfabian
left a comment
peterfabian
left a comment
There was a problem hiding this comment.
Works as advertised. Thanks!
Contributor
|
Tests passed, so merging. |
Contributor
|
Hi @peterfabian, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
roykho
added a commit
that referenced
this pull request
Oct 3, 2022
* Fix: can't place orders for Saint Martin (#34920) * Prep for cherry pick 34920 Co-authored-by: Néstor Soriano <[email protected]> Co-authored-by: WooCommerce Bot <[email protected]> Co-authored-by: Roy Ho <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes #34911 by completing the change implemented in #34014
Closes #34911.
How to test the changes in this Pull Request:
In WooCommerce 7.0 RC try to place and order with Saint Martin (French part) as the country in the billing of shipping address. Without the fix you'll get a "State is required" error and you're stuck. With the fix the order is placed successfully.
Other information:
pnpm --filter=<project> run changelog add?FOR PR REVIEWER ONLY: