Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Sep 30, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #33986.

This PR fixes the confusing UI when clicking the disabled "Continue" button during OBW.

Before:

33986.mp4

After:

Screen.Recording.2022-09-28.at.10.14.03.mov

How to test the changes in this Pull Request:

  1. Go to OBW
  2. Click "Continue" and confirm that it's disabled completely.
  3. Select a Country and go to the next step
  4. Click "Continue" and confirm that it's disabled completely.
  5. Select an industry and go to the next step
  6. Uncheck Physical products option
  7. Click "Continue" and confirm that it's disabled completely.
  8. Select a products type and go to the next step
  9. Click "Continue" and confirm that it's disabled completely.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Sep 30, 2022
@chihsuan chihsuan marked this pull request as ready for review September 30, 2022 06:29
@chihsuan chihsuan self-assigned this Sep 30, 2022
@chihsuan chihsuan requested a review from a team September 30, 2022 06:30
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022

Test Results Summary

Commit SHA: 38a178e

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 45s
E2E Tests187002018915m 38s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@chihsuan chihsuan force-pushed the fix/33986-obw-validation-issue branch from 04f144e to 38a178e Compare October 3, 2022 05:14
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this 😀

@chihsuan chihsuan merged commit 4a39091 into trunk Oct 3, 2022
@chihsuan chihsuan deleted the fix/33986-obw-validation-issue branch October 3, 2022 08:32
@github-actions github-actions bot added this to the 7.1.0 milestone Oct 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup Wizard validation issue in Industry & Business Details Tabs

3 participants