Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Sep 28, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes 92-gh-woocommerce/team-ghidorah.

  • Deploy the treatment and replace the control code.
  • Clean-up remaining experiment code.

How to test the changes in this Pull Request:

  1. Use a fresh site
  2. Navigate to Tools > WCA Test Helper > Experiments
  3. Set woocommerce_products_task_layout_card_v3 and woocommerce_products_task_layout_stacked_v3 to control
  4. Go to Products > All products
  5. Click on "Create Product" button
  6. Observer that spotlight product tour is shown.
  7. Go to WooCommerce > Home > Add products
  8. Click on "Start with a template" and choose a template
  9. Confirm that spotlight product tour is shown.
  10. Repeat 5~7 steps with different templates
  11. Repeat 5 step and choose "Add manually" option.
  12. Confirm that spotlight product tour is shown.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Sep 28, 2022
@chihsuan chihsuan self-assigned this Sep 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

Test Results Summary

Commit SHA: d8cda52

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 47s
E2E Tests187002018915m 28s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@chihsuan chihsuan force-pushed the update/deploy-spotlight-product-tour branch from 4e04159 to 164c193 Compare September 29, 2022 01:30
@chihsuan chihsuan marked this pull request as ready for review September 29, 2022 01:33
@chihsuan chihsuan requested a review from a team September 29, 2022 01:34
@chihsuan chihsuan force-pushed the update/deploy-spotlight-product-tour branch from 164c193 to 8e5ee74 Compare September 30, 2022 03:56
@chihsuan chihsuan force-pushed the update/deploy-spotlight-product-tour branch from 8e5ee74 to d8cda52 Compare October 3, 2022 05:14
Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested well and looks great! Thanks @chihsuan 🚀

@chihsuan chihsuan merged commit 5f2aa49 into trunk Oct 3, 2022
@chihsuan chihsuan deleted the update/deploy-spotlight-product-tour branch October 3, 2022 08:34
@github-actions github-actions bot added this to the 7.1.0 milestone Oct 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants