Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Sep 27, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #34760.

Enable guided mode button will not trigger when its text is translated

This PR fixes it by using a class selector directly.

How to test the changes in this Pull Request:

  1. Navigate to Tools > WCA Test Helper > Experiments
  2. Setwoocommerce_products_task_layout_card_v3 and woocommerce_products_task_layout_stacked_v3 to control
  3. Set woocommerce_products_tour to treatment
  4. Change your site language to Español on Setting page
  5. Go to Escritorio > Actualizaciones (/wp-admin/update-core.php)
  6. Click on Actualizar las traducciones button to download woocommerce transalation
  7. Go to WooCommerce > Home > "Añadir products" (Add products) task
  8. Select Empieza con una plantilla > Producto físico (Physical product) and click "go"
  9. Dismiss product spotlight tour
  10. Click on Activar el modo guiado button
  11. Observe that the product spotlight tour is shown again.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Sep 27, 2022
@chihsuan chihsuan self-assigned this Sep 27, 2022
@chihsuan chihsuan requested a review from a team September 27, 2022 02:55
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022

Test Results Summary

Commit SHA: cf96c0b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 55s
E2E Tests185002018717m 27s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, thanks for fixing, @chihsuan! 🚢

@chihsuan chihsuan merged commit 84641b1 into trunk Sep 27, 2022
@chihsuan chihsuan deleted the fix/34760-enable-guided-mode-button branch September 27, 2022 08:12
@github-actions github-actions bot added this to the 7.1.0 milestone Sep 27, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable guided mode button will not trigger when its text is translated

3 participants