Skip to content

Fix failing to update onboarding profile data for PHP 8 #34832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 4 commits into from
Sep 27, 2022
Merged

Fix failing to update onboarding profile data for PHP 8 #34832

chihsuan merged 4 commits into from
Sep 27, 2022

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Sep 26, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #34745, #34815, #34817.

This PR fixes an updating industries bug. This bug also causes the shipping task display issue (#34815) and saving store address issue (#34817).

It throws an error because rest_validate_request_arg is not a class method but a WP function.

How to test the changes in this Pull Request:

You can use this zip https://github.com/woocommerce/woocommerce/actions/runs/3126273256

Test update industries

  1. Create any test site using Atomic site (or site with PHP 8).
  2. Start OBW.
  3. Fill the Store address and click on Continue.
  4. Select any options from Industry tab.
  5. Click on Continue.
  6. Observe that "There was a problem updating your industries" notification should NOT displayed.

Test shipping task

  1. Create any test site using Atomic site (or site with PHP 8).
  2. Install and activate all the required plugins.
  3. Complete the Onboarding setup wizard.
  4. Go to Woocommerce > Home
  5. Observe that "Shipping task" is displayed on Woocommerce > Home page after completing OBW.

Test saving the store address

  1. Create any test site using Atomic site (or site with PHP 8).
  2. Install and activate all the required plugins.
  3. Complete the Onboarding setup wizard.
  4. Start OBW.
  5. Fill Store address and Email Address.
  6. Click on Contiune.
  7. Click on Store details header.
  8. Observe that "Country/ Region" and "Email address" are saved properly

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@chihsuan chihsuan self-assigned this Sep 26, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Sep 26, 2022
@chihsuan chihsuan added the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Sep 26, 2022
@chihsuan chihsuan added this to the 7.0.0 milestone Sep 26, 2022
@chihsuan chihsuan changed the title Fix failing to update industries after clicking "Continue" on "Industry" tab. Fix failing to update onboarding profile data for PHP 8 Sep 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 774a5f4

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201201m 3s
E2E Tests185002018713m 58s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@chihsuan chihsuan requested a review from a team September 26, 2022 09:00
ilyasfoo
ilyasfoo approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, thanks @chihsuan! :shipit:

@chihsuan chihsuan merged commit ab484e5 into trunk Sep 27, 2022
@chihsuan chihsuan deleted the fix/34745-update-industries-error branch September 27, 2022 05:50
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Sep 27, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Sep 27, 2022
@chihsuan
Fix failing to update onboarding profile data for PHP 8 (#34832)
915b7db 
* Fix failing to update industries

* Add changelog

* Update changelog

* Update onboarding profile unit tests to test all schema fields
@github-actions github-actions bot mentioned this pull request Sep 27, 2022
Merged
roykho pushed a commit that referenced this pull request Sep 27, 2022
@github-actions @chihsuan
Cherry pick 34832 into release/7.0 (#34845)
9ece6b5 
* Fix failing to update onboarding profile data for PHP 8 (#34832)

* Fix failing to update industries

* Add changelog

* Update changelog

* Update onboarding profile unit tests to test all schema fields

* Prep for cherry pick 34832

Co-authored-by: Chi-Hsuan Huang <[email protected]>
Co-authored-by: WooCommerce Bot <[email protected]>
@roykho roykho removed the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[GlobalStep] For Atomic site, "There was a problem updating your industries" notification displayed after clicking "Continue" on "Industry" tab.

4 participants

@chihsuan @ilyasfoo @roykho