Skip to content

Remove the check for plugins: woocommerce label #34820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roykho merged 1 commit into from
Sep 23, 2022
Merged

Remove the check for plugins: woocommerce label #34820

roykho merged 1 commit into from
Sep 23, 2022

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Sep 23, 2022

All Submissions:

Changes proposed in this Pull Request:

This PR removes the check for the plugins: woocommerce label as a validation to add milestone to the merged PR. This is an interim solution to this issue

How to test the changes in this Pull Request:

  1. N/A

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

jonathansadowski
jonathansadowski approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@jonathansadowski jonathansadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for this... this'll make sure that none of the PRs affecting a core release get missed until #34767 can be addressed

@roykho roykho merged commit 18901f1 into trunk Sep 23, 2022
@roykho roykho deleted the dev/milestone-all-prs branch September 23, 2022 19:11
@github-actions github-actions bot added this to the 7.1.0 milestone Sep 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

Hi @roykho, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@roykho roykho mentioned this pull request Sep 23, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

Test Results Summary

Commit SHA: e4cb2de

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201201m 1s
E2E Tests185002018721m 33s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Konamiman pushed a commit that referenced this pull request Sep 27, 2022
@roykho @Konamiman
Remove the check for plugins: woocommerce label (#34820)
0fce9ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonathansadowski jonathansadowski jonathansadowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@roykho @jonathansadowski