-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add initial attributes section for empty state #34751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results SummaryCommit SHA: 5b69b84
To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
| } ); | ||
|
|
||
| describe( 'empty state', () => { | ||
| it( 'should show subittle and "Add first attribute" button', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a typo here subittle.
| recordEvent( 'add_product_pricing_help' ); | ||
| } } | ||
| > | ||
| How to price your product: expert tips |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this. I added this same fix to this PR. I'll remove it later from mine.
octaedro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did a great job here @louwie17. This is testing well on my end and the code LGTM 🚀
7b15103 to
5b69b84
Compare
octaedro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ![]()
|
Hi @louwie17, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
All Submissions:
Changes proposed in this Pull Request:
Adds the initial attributes section for product with no attributes yet. This should follow the design, the Add first attribute button currently disabled as this would be done as part of: #34331
Closes #34330 .
How to test the changes in this Pull Request:
new-product-management-experiencefeature flag by using the WCA Test Helper (Tools > WCA Test Helper > Features) and refresh the page.Other information:
pnpm changelog add --filter=<project>?FOR PR REVIEWER ONLY: