Skip to content

Conversation

@louwie17
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Adds the initial attributes section for product with no attributes yet. This should follow the design, the Add first attribute button currently disabled as this would be done as part of: #34331

Screen Shot 2022-09-20 at 3 39 22 PM

Closes #34330 .

How to test the changes in this Pull Request:

  1. Load this branch and enable the new-product-management-experience feature flag by using the WCA Test Helper (Tools > WCA Test Helper > Features) and refresh the page.
  2. Click the Products > Add New (MVP) button and notice the new attributes section
  3. It should look the same as the design here: 5sAIeTRd9Yp7nSCT33BAWz-fi-6823%3A312388 the only difference is that the add new button is disabled.
  4. Check that the link in the Section description links to this documentation page in a new tab.
  5. Save this Product and add some attributes using the old UI
  6. Refresh the page, the attributes empty state section should now be gone ( as this will be done as part of [Attributes] Attribute list #34333 )

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@louwie17 louwie17 requested a review from a team September 20, 2022 18:53
@github-actions github-actions bot added focus: react admin package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Sep 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2022

Test Results Summary

Commit SHA: 5b69b84

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 57s
E2E Tests185002018717m 23s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@octaedro octaedro requested review from octaedro and removed request for a team September 26, 2022 13:26
} );

describe( 'empty state', () => {
it( 'should show subittle and "Add first attribute" button', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a typo here subittle.

recordEvent( 'add_product_pricing_help' );
} }
>
How to price your product: expert tips
Copy link
Contributor

@octaedro octaedro Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. I added this same fix to this PR. I'll remove it later from mine.

octaedro
octaedro previously approved these changes Sep 26, 2022
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a great job here @louwie17. This is testing well on my end and the code LGTM 🚀

Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@louwie17 louwie17 merged commit c01c48c into trunk Sep 26, 2022
@louwie17 louwie17 deleted the add/34330_attributes_section branch September 26, 2022 17:44
@github-actions github-actions bot added this to the 7.1.0 milestone Sep 26, 2022
@github-actions
Copy link
Contributor

Hi @louwie17, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Attributes] Empty state

3 participants