-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Only show the product image upload tip once, and on all product edit pages #34739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results SummaryCommit SHA: c44157a
To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Would it be better to make the max file size the PHP upload size limit. I wouldn't have thought that 2GB was a realistic upload size for most hosting. Unless thats a limit of something else. The intention of this message is presumably originally to be helpful to a more non technical user. |
|
@mattsherman - I have found the cause: disabling All in One SEO Pro plugin will eliminate this error (at least in case of the shops managed by me). |
Totally. Thanks for pointing this out!
Agreed. It is not! |
louwie17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on this so quickly @mattsherman, and nice straight forward fix, this tested well.
|
Hi @mattsherman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
…pages (#34739) * Only show the product image upload tip once, and on all product edit pages. * Use max upload size in message.
…pages (#34739) * Only show the product image upload tip once, and on all product edit pages. * Use max upload size in message.
…pages (#34739) * Only show the product image upload tip once, and on all product edit pages. * Use max upload size in message.
All Submissions:
Changes proposed in this Pull Request:
In WooCommerce 6.9, a tip was added under the product image thumbnail in the sidebar of the product edit page (see #33660).
Under certain circumstances, this tip can be rendered multiple times.
This is because the
add_filtercall is incorrectly called from the constructor of theWC_Simple_Productclass. This is not a good location to calladd_filterbecause:WC_Simple_Productinstances while rendering the product edit page, andWC_Simple_Productconstructor, it doesn't appear for other product types, such as variable products.I've changed the implementation to work when editing any product type and to only render a single time.
Fixes #34728.
How to test the changes in this Pull Request:
Other information:
pnpm changelog add --filter=<project>?FOR PR REVIEWER ONLY: