Skip to content

Conversation

@vedanshujain
Copy link
Contributor

Reverts #34616 as CI is failing after the merge. We will reintroduce this again if CI passes.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Sep 16, 2022
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 702ad0c

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 42s
E2E Tests185101018720m 40s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert looks good, though I note some checks including Run tests against PR / Runs E2E tests continue to fail.

Will go ahead and merge and we can take another look at this body of work next week.

@barryhughes barryhughes merged commit 7cec9b4 into trunk Sep 16, 2022
@barryhughes barryhughes deleted the revert-34616-add/features-controller-with-plugin-compatibility-declaration branch September 16, 2022 18:06
@github-actions github-actions bot added this to the 7.1.0 milestone Sep 16, 2022
@github-actions
Copy link
Contributor

Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants