Test Results Summary

Hey @xristos3490 Thanks for adding the header! Could you please add some test instructions as you added in #34697? Thank you!

BTW, e2e tests gh action is failing. I think you can try rebasing the branch. 🙂

Needs design feedback.

Hey @verofasulo When you get a chance, could you confirm if the design look good? Thanks! 🙏

Hey @chihsuan, thanks for the ping!

could you confirm if the design look good?

The header looks great! The only thing misaligned with what Jarek designed is the section with the progress bar - I attach a screenshot:

Figma: ZP87x6cY7eOHkfKVXwh1hQ-fi-2%3A1126

Hey @verofasulo!

The header looks great! The only thing misaligned with what Jarek designed is the section with the progress bar.

Thanks for raising this concern! I was skeptical about it, too. It seems that a recent work to fix the header in the sidebar introduced a white box around this stepper.

I wrote about the sidebar styling issue in an internal discussion with @chihsuan. Should we revisit?

More at peapX7-jn-p2#comment-218

PS. Another minor change in the description differs from the Figma file, as this step doesn't include any "industry" fields, only the store location.

Hey @xristos3490

I wrote about the sidebar styling issue in an internal discussion with @chihsuan. Should we revisit?

Yes, please 😊 The current style makes them appear as two different sections while they both belong to the task list area. Thank you!

PS. Another minor change in the description differs from the Figma file, as this step doesn't include any "industry" fields, only the store location.

You're right, I didn't notice it! Please do not implement the "industry" part - refer to the initial design with the store address only for the copy 🙏

Yes, please 😊 The current style makes them appear as two different sections while they both belong to the task list area. Thank you!

Ah, as @verofasulo said. ⬆️ Thanks for catching that! @xristos3490 🙏

Thanks for all the help, everyone! 🙇

I've pushed a minor CSS fix that should revert the progress header style. Here's how it looks right now in the Home page and in the activity sidebar:

I wonder if there is an issue with the line-height in the sidebar's header?

As a side note, the progress value seems to have this blue hardcoded. Is that on purpose? Should we consider changing this to the theme's primary color?

e.g. on Ecommerce plan change this:

to this:

Note: Ignore the dots menu; it shouldn't be there.

Thoughts?

Hey, @xristos3490! Thanks for catching the header issue. I noticed that the ellipsis next to the header are also hidden. I believe this was caused by this commit, which I think was intended but possibly mismatched the design.

Edit: Sorry if this is a bit too much, but feel free to skip this comment if you think it's better to address this elsewhere 😅

Hey @ilyasfoo! Thanks for chiming in!

Nice catch! The dots menu needs to be there.

It's done at bc5a848

I've pushed a commit to align the dots menu in the sidebar. This led to a tiny refactor to keep all the sidebar-related rules in one place. Please let me know what you think!

This new structure led to fixing a priority-related bug for the h1 rules for the sidebar.

Ref screenshot:

I wonder if there is an issue with the line-height in the sidebar's header? -- #34712 (comment)

Here's what the sidebar looks like now: 😃

As a side note, the progress value seems to have this blue hardcoded. Is that on purpose? Should we consider changing this to the theme's primary color?

@xristos3490 I think we should change it to the theme's primary color. cc @verofasulo

Here's what the sidebar looks like now: 😃

Thanks for fixing it! That looks perfect. 😄

I think we should change it to the theme's primary color

Yes, totally! Thanks for spotting that @xristos3490 @chihsuan 🙌

Thanks for all the help, @chihsuan!

Hi @xristos3490, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

• Add the release: add testing instructions label